Juhani Numminen
c9de855dd8
Install icons to standard locations for linux desktop
...
Also reorganize icons in subdirectories indicating size.
See the Icon Theme Specification:
https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#install_icons
2019-07-18 11:09:08 +03:00
Shlomi Fish
9a51c55402
list prereqs.
...
See https://caremad.io/posts/2013/07/setup-vs-requirement/ .
2019-07-16 21:03:51 +03:00
Juhani Numminen
3e873a3fde
Delete local copy of configobj in favor of the pypi package
...
The "validate" module does come in the same pypi package.
2019-07-16 12:57:24 +03:00
Shlomi Fish
7934babad2
Extract a method or a function.
...
This is Refactoring / code cleanup.
See:
* https://refactoring.com/catalog/extractMethod.html
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-07-15 17:17:04 +03:00
Shlomi Fish
62005c7c42
Extract a common class/struct.
...
This is Refactoring / code cleanup.
See:
* https://en.wikipedia.org/wiki/God_object
* https://en.wikipedia.org/wiki/Extract_class
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-07-15 14:17:03 +03:00
Shlomi Fish
c30d131181
install the attrs.py deps.
2019-07-15 12:52:19 +03:00
Shlomi Fish
18efc0e5d3
Extract a common class/struct.
...
This is Refactoring / code cleanup.
See:
* https://en.wikipedia.org/wiki/God_object
* https://en.wikipedia.org/wiki/Extract_class
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-07-14 22:56:06 +03:00
Juhani Numminen
63c6aa5816
Don't duplicate locales, e.g. de -> de_DE
...
The duplication seems to be unnecessary. Setting environment variable
LANG=it_CH gives Italian as PySolFC language, even if we didn't explicitly
create 'it_CH'.
2019-07-14 14:02:43 +03:00
Juhani Numminen
5062f0e0d9
Install all translations, not only Russian
2019-07-14 14:02:32 +03:00
Shlomi Fish
0aad4261d8
appveyor fix #1 - os.sep
2019-07-14 08:58:46 +03:00
Juhani Numminen
c13b8587fc
Update pysol.desktop for unix desktop integration
...
Encoding has been deprecated - see https://specifications.freedesktop.org/desktop-entry-spec/1.0/apc.html
StartupWMClass adds a startup animation. xprop was used to find out the value for WM_CLASS; it was tested on KDE Plasma 5.
2019-07-13 16:53:14 +03:00
Shlomi Fish
41b4e75f15
fix travis / dist tests.
2019-06-24 18:12:24 +03:00
Shlomi Fish
69a2036f94
remove pointless comments
2019-06-24 17:23:13 +03:00
Shlomi Fish
7cb6d9c8b5
extract a method.
2019-06-24 16:53:57 +03:00
Shlomi Fish
fd797ffbf5
fix pysol --deal 1/24/1000.
...
Low ms deals without the ms prefix caused an error.
2019-06-05 15:06:51 +03:00
Shlomi Fish
4a53c175f5
Extract ms_rearrange .
2019-06-05 15:00:12 +03:00
Shlomi Fish
86d2e6368f
speedup.
...
See https://github.com/shlomif/PySolFC/issues/119 .
2019-06-04 22:31:27 +03:00
Shlomi Fish
843d74d90f
Extract a function or class to step away from God Object.
...
See:
* https://en.wikipedia.org/wiki/God_object
* https://www.c-sharpcorner.com/article/god-object-a-code-smell/ .
This is Refactoring / code cleanup.
See:
* https://refactoring.com/catalog/extractMethod.html
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-06-04 16:05:10 +03:00
Shlomi Fish
ebbb1313e9
refactoring
2019-06-04 15:36:45 +03:00
Shlomi Fish
7bbddccf80
refactoring
2019-06-04 15:27:37 +03:00
Shlomi Fish
d8e7a3e3ef
Extract a function or class to step away from God Object.
...
See:
* https://en.wikipedia.org/wiki/God_object
* https://www.c-sharpcorner.com/article/god-object-a-code-smell/ .
This is Refactoring / code cleanup.
See:
* https://refactoring.com/catalog/extractMethod.html
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-06-04 15:12:39 +03:00
Shlomi Fish
c12be2eaed
optimization
2019-05-31 19:28:27 +03:00
Shlomi Fish
b6da50d20f
Extract a function or class to step away from God Object.
...
See:
* https://en.wikipedia.org/wiki/God_object
* https://www.c-sharpcorner.com/article/god-object-a-code-smell/ .
This is Refactoring / code cleanup.
See:
* https://refactoring.com/catalog/extractMethod.html
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-05-31 19:23:27 +03:00
Shlomi Fish
75ffea5005
Extract a method or a function.
...
This is Refactoring / code cleanup.
See:
* https://refactoring.com/catalog/extractMethod.html
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-05-31 18:32:47 +03:00
Shlomi Fish
a073d20af7
Refactoring / code cleanup.
...
See:
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-05-31 18:09:57 +03:00
Shlomi Fish
9acc97be8a
Refactoring / code cleanup.
...
See:
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-05-31 17:22:49 +03:00
Shlomi Fish
26e5aeb045
Rename variable/s to make them more descriptive.
...
dir is a py builtin.
2019-05-31 16:42:57 +03:00
Shlomi Fish
32411ab0ec
Refactoring.
2019-05-31 16:32:24 +03:00
Shlomi Fish
efddc917b2
Extract a method or a function.
...
This is Refactoring / code cleanup.
See:
* https://refactoring.com/catalog/extractMethod.html
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-05-31 16:03:22 +03:00
Shlomi Fish
2bec58be2d
Fix next deal / Ctrl+N for ms deals.
2019-05-23 19:10:57 +03:00
Shlomi Fish
74441a1746
Convert functionality to pysol-cards mod.
2019-05-23 17:26:27 +03:00
Shlomi Fish
4853b2dc5f
pickle backcompat.
2019-05-16 18:46:05 +03:00
Shlomi Fish
2d60bdf726
travis / py3 fix - str.replace.
2019-05-05 21:16:07 +03:00
Shlomi Fish
6fbbe82593
Link to PySolFC-Cardsets.
...
See https://github.com/shlomif/PySolFC/issues/113 .
2019-05-05 18:34:32 +03:00
Shlomi Fish
76804c6d76
flake8
2019-04-30 18:25:01 +03:00
Shlomi Fish
9142b90cb2
Refactoring / code cleanup.
...
Remove the unused "Comments" class.
See:
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-04-30 17:49:36 +03:00
Shlomi Fish
ea73eb32a3
refactoring
2019-04-30 17:40:18 +03:00
Shlomi Fish
6317008876
traverse the tree for matching modules.
...
To avoid misses.
2019-04-30 17:35:43 +03:00
Shlomi Fish
33c8f6e375
add tests.
2019-04-30 17:20:47 +03:00
Shlomi Fish
824407b136
Extract a common module/library/header.
...
This is Refactoring / code cleanup.
See:
* https://refactoring.com/catalog/extractMethod.html
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-04-30 17:14:57 +03:00
Shlomi Fish
9af86cddfb
Extract a common module/library/header.
...
This is Refactoring / code cleanup.
See:
* https://refactoring.com/catalog/extractMethod.html
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-04-29 15:14:36 +03:00
Shlomi Fish
90323173a7
Extract a common module/library/header.
...
This is Refactoring / code cleanup.
See:
* https://refactoring.com/catalog/extractMethod.html
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-04-29 15:08:04 +03:00
Shlomi Fish
9e148b88fe
implement the --deal command line param.
...
It implements a starting deal seed/index/number.
2019-04-29 14:51:01 +03:00
Shlomi Fish
da256a30b0
use normal print to avoid b"...".
2019-04-29 14:25:04 +03:00
Shlomi Fish
cb25f39136
abort on invalid command line game.
2019-04-29 14:24:21 +03:00
Shlomi Fish
4cb94702f3
Add the release process documentation.
2019-04-25 22:22:49 +03:00
Shlomi Fish
436bca2852
Add missing NEWS and AUTHORS to the source dist.
2019-04-25 22:06:16 +03:00
Shlomi Fish
918f177acc
prepare for v2.6.4 release.
2019-04-25 21:23:56 +03:00
Roderik Ploszek
9bf8f475bb
Fix Three Peaks scoring
...
Score is correctly updated after moving a card to the waste stack or
after winning a game. Double counting is prevented by the score_counted
variable.
see https://github.com/shlomif/PySolFC/issues/111
2019-04-22 09:28:18 +02:00
Shlomi Fish
961634e685
travis ci: fix #1 - failing tests
2019-04-08 20:03:53 +03:00
