anthonycicc/PySolFC
1
0
Fork 0
mirror of https://github.com/shlomif/PySolFC.git synced 2025-04-05 00:02:29 -04:00
Code Releases Activity

Refactoring / code cleanup.

Browse source 
See:

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
This commit is contained in:
Shlomi Fish 2019-05-31 18:09:57 +03:00
parent 9acc97be8a
commit a073d20af7
2 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pysollib/actions.py
View file

@ -330,7 +330,7 @@ class PysolMenubar(PysolMenubarTk):
elif type == 'not played' and won+lost == 0:
games.append(gi.id)
if games:
game_id = self.app.getRandomGameId(games)
game_id = self.app.chooseRandomOutOfGames(games)
if game_id and game_id != self.game.id:
self.game.endGame()
self.game.quitGame(game_id)

12
pysollib/app.py
View file

@ -1017,10 +1017,14 @@ Please select a %s type %s.
return None
return re.sub(r"[\s]", "_", latin1_normalize(n))
def getRandomGameId(self, games=None):
if games is None:
return self.miscrandom.choice(self.gdb.getGamesIdSortedById())
return self.miscrandom.choice(games)
def _choice(self, lst):
return self.miscrandom.choice(lst)
def chooseRandomOutOfGames(self, games):
return self._choice(games)
def getRandomGameId(self):
return self._choice(self.gdb.getGamesIdSortedById())
def getAllUserNames(self):
names = []