1
0
Fork 0
mirror of https://github.com/shlomif/PySolFC.git synced 2025-04-05 00:02:29 -04:00
Commit graph

1245 commits

Author SHA1 Message Date
Shlomi Fish
8fe6098b64 fix the py2 tests / code:
https://github.com/shlomif/PySolFC/issues/119
2019-06-04 21:35:04 +03:00
Shlomi Fish
1184ae38fb Revert "Convert functionality to pysol-cards mod."
This reverts commit 74441a1746 which
appears to have caused a tests slowdown:

https://github.com/shlomif/PySolFC/issues/119 .
2019-06-04 21:25:50 +03:00
Shlomi Fish
843d74d90f Extract a function or class to step away from God Object.
See:

* https://en.wikipedia.org/wiki/God_object

* https://www.c-sharpcorner.com/article/god-object-a-code-smell/ .

This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2019-06-04 16:05:10 +03:00
Shlomi Fish
ebbb1313e9 refactoring 2019-06-04 15:36:45 +03:00
Shlomi Fish
7bbddccf80 refactoring 2019-06-04 15:27:37 +03:00
Shlomi Fish
d8e7a3e3ef Extract a function or class to step away from God Object.
See:

* https://en.wikipedia.org/wiki/God_object

* https://www.c-sharpcorner.com/article/god-object-a-code-smell/ .

This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2019-06-04 15:12:39 +03:00
Shlomi Fish
c12be2eaed optimization 2019-05-31 19:28:27 +03:00
Shlomi Fish
b6da50d20f Extract a function or class to step away from God Object.
See:

* https://en.wikipedia.org/wiki/God_object

* https://www.c-sharpcorner.com/article/god-object-a-code-smell/ .

This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2019-05-31 19:23:27 +03:00
Shlomi Fish
75ffea5005 Extract a method or a function.
This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2019-05-31 18:32:47 +03:00
Shlomi Fish
a073d20af7 Refactoring / code cleanup.
See:

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2019-05-31 18:09:57 +03:00
Shlomi Fish
9acc97be8a Refactoring / code cleanup.
See:

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2019-05-31 17:22:49 +03:00
Shlomi Fish
26e5aeb045 Rename variable/s to make them more descriptive.
dir is a py builtin.
2019-05-31 16:42:57 +03:00
Shlomi Fish
32411ab0ec Refactoring. 2019-05-31 16:32:24 +03:00
Shlomi Fish
efddc917b2 Extract a method or a function.
This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2019-05-31 16:03:22 +03:00
Shlomi Fish
2bec58be2d Fix next deal / Ctrl+N for ms deals. 2019-05-23 19:10:57 +03:00
Shlomi Fish
74441a1746 Convert functionality to pysol-cards mod. 2019-05-23 17:26:27 +03:00
Shlomi Fish
4853b2dc5f pickle backcompat. 2019-05-16 18:46:05 +03:00
Shlomi Fish
2d60bdf726 travis / py3 fix - str.replace. 2019-05-05 21:16:07 +03:00
Shlomi Fish
6fbbe82593 Link to PySolFC-Cardsets.
See https://github.com/shlomif/PySolFC/issues/113 .
2019-05-05 18:34:32 +03:00
Shlomi Fish
76804c6d76 flake8 2019-04-30 18:25:01 +03:00
Shlomi Fish
9142b90cb2 Refactoring / code cleanup.
Remove the unused "Comments" class.

See:

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2019-04-30 17:49:36 +03:00
Shlomi Fish
ea73eb32a3 refactoring 2019-04-30 17:40:18 +03:00
Shlomi Fish
6317008876 traverse the tree for matching modules.
To avoid misses.
2019-04-30 17:35:43 +03:00
Shlomi Fish
33c8f6e375 add tests. 2019-04-30 17:20:47 +03:00
Shlomi Fish
824407b136 Extract a common module/library/header.
This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2019-04-30 17:14:57 +03:00
Shlomi Fish
9af86cddfb Extract a common module/library/header.
This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2019-04-29 15:14:36 +03:00
Shlomi Fish
90323173a7 Extract a common module/library/header.
This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2019-04-29 15:08:04 +03:00
Shlomi Fish
9e148b88fe implement the --deal command line param.
It implements a starting deal seed/index/number.
2019-04-29 14:51:01 +03:00
Shlomi Fish
da256a30b0 use normal print to avoid b"...". 2019-04-29 14:25:04 +03:00
Shlomi Fish
cb25f39136 abort on invalid command line game. 2019-04-29 14:24:21 +03:00
Shlomi Fish
4cb94702f3 Add the release process documentation. 2019-04-25 22:22:49 +03:00
Shlomi Fish
436bca2852 Add missing NEWS and AUTHORS to the source dist. 2019-04-25 22:06:16 +03:00
Shlomi Fish
918f177acc prepare for v2.6.4 release. 2019-04-25 21:23:56 +03:00
Roderik Ploszek
9bf8f475bb Fix Three Peaks scoring
Score is correctly updated after moving a card to the waste stack or
after winning a game. Double counting is prevented by the score_counted
variable.

see https://github.com/shlomif/PySolFC/issues/111
2019-04-22 09:28:18 +02:00
Shlomi Fish
961634e685 travis ci: fix #1 - failing tests 2019-04-08 20:03:53 +03:00
Shlomi Fish
3ce505826e add credits 2019-04-08 19:03:49 +03:00
Shlomi Fish
d082812426 convert to markdown 2019-04-08 18:53:24 +03:00
Shlomi Fish
d3561e0e77 merge differences between */toolbar.py.
Refactoring.
2019-04-08 18:34:27 +03:00
Shlomi Fish
a452aba812 update the logo url in the html. 2019-04-08 17:45:44 +03:00
ghostofiht
1477ee275e
logo updated 2019-04-08 16:28:17 +03:00
ghostofiht
a54b87c722
Delete logo_horizontal.svg 2019-04-08 16:28:03 +03:00
ghostofiht
dbba3af299
logo updated 2019-04-08 16:24:46 +03:00
ghostofiht
18b4171e7f
Delete logo_horizontal.png.svg 2019-04-08 16:24:33 +03:00
ghostofiht
24ff063652
logo updated 2019-04-08 16:23:40 +03:00
ghostofiht
f919ff690e
logo added 2019-04-08 15:52:58 +03:00
ghostofiht
4126d48c78
logo updated 2019-04-08 15:46:47 +03:00
Shlomi Fish
0696750457 bump version to 2.6.3 2019-04-07 13:40:31 +03:00
Shlomi Fish
7593aaed4c First version of the NEWS file.
Based on the site's front page - thanks to https://pandoc.org/ .
2019-04-06 21:48:38 +03:00
Shlomi Fish
1d3ffc4e1d Try fixing issue #108 - compat with pillow 6.0
See https://github.com/shlomif/PySolFC/issues/108 .
2019-04-05 17:37:04 +03:00
Shlomi Fish
2e67242e92 Fix the window size on startup.
See https://github.com/shlomif/PySolFC/issues/84 :

<<<

Yes, I can confirm that the "Save games geometry" option is present in
that build, and that it works! +1

The default startup window looks like this though (which is something
that should be addressed):

>>>
2019-04-05 16:26:55 +03:00