anthonycicc/PySolFC
1
0
Fork 0
mirror of https://github.com/shlomif/PySolFC.git synced 2025-04-05 00:02:29 -04:00
Code Releases Activity
1238 commits 57 branches 40 tags 257 MiB
Commit graph

129 commits

Author SHA1 Message Date
Shlomi Fish
b6da50d20f Extract a function or class to step away from God Object. 
See:

* https://en.wikipedia.org/wiki/God_object

* https://www.c-sharpcorner.com/article/god-object-a-code-smell/ .

This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
 2019-05-31 19:23:27 +03:00
Shlomi Fish
9acc97be8a Refactoring / code cleanup. 
See:

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
 2019-05-31 17:22:49 +03:00
Shlomi Fish
76804c6d76 flake8 2019-04-30 18:25:01 +03:00
Shlomi Fish
2e67242e92 Fix the window size on startup. 
See https://github.com/shlomif/PySolFC/issues/84 :

<<<

Yes, I can confirm that the "Save games geometry" option is present in
that build, and that it works! +1

The default startup window looks like this though (which is something
that should be addressed):

>>>
 2019-04-05 16:26:55 +03:00
Shlomi Fish
48e24c2021 try fix save games geometry. 
See https://github.com/shlomif/PySolFC/issues/84 .
 2019-04-04 13:11:44 +03:00
Shlomi Fish
ed18fd8156 Order imports based on flake8-import-order. 
Tested on ci. See https://github.com/PyCQA/flake8-import-order . In the
process did some other cleanups and
https://en.wikipedia.org/wiki/Code_refactoring .
 2019-01-11 23:55:06 +02:00
Shlomi Fish
908de63d9f Fix flake8 tests. 
For the new flake8.
 2018-11-11 22:43:36 +02:00
Shlomi Fish
11bafeba44 use six.py. 2018-09-01 18:40:50 +03:00
Shlomi Fish
ead4b9212a avoid unneeded py3 shims. 2018-09-01 17:54:48 +03:00
lb@lb520
3e9b7b74c7 Bugfix synchronisation issues with autodrop 
Bugfix bottom image flip
 2018-03-22 15:48:19 +01:00
Shlomi Fish
1394c0df8f Refactoring 2018-03-14 19:46:16 +02:00
Shlomi Fish
77a5b47e98 Refactoring - based on fc-solve. 2018-03-14 19:31:39 +02:00
Shlomi Fish
bc25ff5574 Refactoring: extract a closure. 2018-03-14 19:20:36 +02:00
Shlomi Fish
d49c0103f4 Refactoring 2018-03-13 15:46:24 +02:00
Shlomi Fish
48cd6abcd5 Refactoring 2018-03-13 15:18:36 +02:00
lb@lb520
b5ef9b6214 Added an alternate toolkit kivy (based on SDL2) that can be used instead of tk. 
Added scripts to build an android app.
 2018-03-03 20:37:56 +02:00
Roderik Ploszek
7dc12168a0 Fix typo in color hex code 
Play mode in solver dialog now works.
 2018-02-24 23:05:20 +01:00
Shlomi Fish
3ada0e3e0b Convert to six.moves. 2018-02-20 01:41:40 +02:00
Shlomi Fish
59d5006c63 Refactor some code. 2018-02-15 21:31:38 +02:00
Shlomi Fish
a803849b35 Working now - import board. 
Mostly at least.
 2017-12-18 21:52:29 +02:00
Shlomi Fish
3fc989ae0a Start implementing board import. 
See https://github.com/shlomif/PySolFC/issues/47 .
 2017-12-18 20:47:10 +02:00
Shlomi Fish
76580b7a3f Extract a method. 2017-11-13 22:27:43 +02:00
Shlomi Fish
4ad3f0f889 Extract a base class/trait for some games. 2017-11-13 21:38:34 +02:00
Shlomi Fish
6cfd8d351e Extract more common methods. 2017-11-09 21:40:42 +02:00
Shlomi Fish
184d4e32db Extract method. 2017-11-09 21:24:35 +02:00
Shlomi Fish
4f2b28e017 Extract another method. 2017-11-09 19:20:41 +02:00
Shlomi Fish
4fc37276aa Extract _startDealNumRows(). Refactoring. 2017-11-09 19:06:59 +02:00
Shlomi Fish
1fda22efbe Start extracting _dealNumRows(). 
A common pattern in the code.
 2017-11-09 18:07:15 +02:00
Shlomi Fish
38bfb88971 Made the new flake8 and travis happier. 
Fix the warnings.
 2017-11-04 20:15:52 +02:00
Shlomi Fish
de93df2de7 flake8 and other tests. 2017-09-18 16:37:02 +03:00
Shlomi Fish
86b243ad53 flake8 2017-09-18 15:37:05 +03:00
Shlomi Fish
dbdd0f392c division sanity 2017-08-25 18:25:58 +03:00
Shlomi Fish
8d9cb53ecc Fix cardset change and similar pickling problems 
see https://github.com/shlomif/PySolFC/issues/41 .
 2017-08-25 18:25:58 +03:00
Shlomi Fish
aa4f9ee5da Crude code to get some func running in py3. 
Right now klondike and freecell sort of work, but this is very hacky and
there are many leftover debug traces.
 2017-08-25 18:25:58 +03:00
Shlomi Fish
890a948d8b Ran 2to3 on pysollib/[a-g]*.py 2017-04-27 21:13:32 +03:00
Shlomi Fish
1ec8cc8b27 flake8 checked g*.py. 2017-04-19 12:03:44 +03:00
Shlomi Fish
c1d7918c27 Fix some typos as reported by codespell. 
Thanks to Jan for inspiring this.
 2017-04-08 19:13:59 +03:00
Shlomi Fish
53fa3e715f Allow to save and restore ms[0-9]+ deals. 2016-11-09 21:25:41 +02:00
Shlomi Fish
cc09f7a5d6 Remove an assertion that did harm. 
See https://github.com/shlomif/PySolFC/issues/12 .
 2016-09-22 13:28:46 +03:00
Shlomi Fish
506a2814e5 Remove trailing space. 2013-04-15 18:53:17 +03:00
Shlomi Fish
5a10318ede Add display and remember for ms[0-9]+ deals. 
This causes them to display in the status bar and also to be remembered
when you choose a new deal.
 2012-12-12 21:30:32 +02:00
Shlomi Fish
55cc8995ae pysoltk. 2012-11-25 19:12:33 +02:00
Shlomi Fish
7ae1fa725d Test and convert "import help". 2012-11-25 19:01:26 +02:00
Shlomi Fish
ab9473fa95 pysollib.game. \o/ 2012-11-25 18:50:10 +02:00
Shlomi Fish
0a7b4f0924 Add pysollib.hint. 2012-11-25 18:30:38 +02:00
Shlomi Fish
61934914b1 import pysollib.pysolrandom. 
Convert to an explicit namespace.
 2012-11-25 18:21:41 +02:00
Shlomi Fish
88634d2a8b import stack. 2012-11-25 18:16:06 +02:00
Shlomi Fish
9252b4771b From pysollib.move. 2012-11-25 18:09:21 +02:00
Shlomi Fish
884a44ceb0 gamedb. 2012-11-25 18:07:40 +02:00
Shlomi Fish
308ede18ff Convert mfxutil and settings imports to pysollib 2012-11-25 17:05:22 +02:00