1
0
Fork 0
mirror of https://github.com/shlomif/PySolFC.git synced 2025-04-22 03:04:09 -04:00
Commit graph

953 commits

Author SHA1 Message Date
Shlomi Fish
b306d78c47 extract a method. 2020-02-09 11:39:38 +02:00
Shlomi Fish
f64875c418 fix pysol --deal 1/24/1000.
Low ms deals without the ms prefix caused an error.
2020-02-09 11:39:38 +02:00
Shlomi Fish
ae16134dce Extract ms_rearrange . 2020-02-09 11:39:38 +02:00
Shlomi Fish
dc1d061103 speedup.
See https://github.com/shlomif/PySolFC/issues/119 .
2020-02-09 11:39:38 +02:00
Shlomi Fish
5a6dcba2fd Extract a function or class to step away from God Object.
See:

* https://en.wikipedia.org/wiki/God_object

* https://www.c-sharpcorner.com/article/god-object-a-code-smell/ .

This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2020-02-09 11:39:38 +02:00
Shlomi Fish
b03e877b3b refactoring 2020-02-09 11:39:38 +02:00
Shlomi Fish
648f3d6bb9 refactoring 2020-02-09 11:39:38 +02:00
Shlomi Fish
bcaa95660b Extract a function or class to step away from God Object.
See:

* https://en.wikipedia.org/wiki/God_object

* https://www.c-sharpcorner.com/article/god-object-a-code-smell/ .

This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2020-02-09 11:39:38 +02:00
Shlomi Fish
78c7e333c4 add a to implement method. 2019-05-31 19:33:02 +03:00
Shlomi Fish
ec808f30e9 implement writeCard. 2019-05-31 19:33:02 +03:00
Shlomi Fish
a15dfe4773 start writing writeCard(). 2019-05-31 19:33:02 +03:00
Shlomi Fish
fc926bb993 refactor. 2019-05-31 19:33:02 +03:00
Shlomi Fish
bbf038300b extract method. 2019-05-31 19:33:02 +03:00
Shlomi Fish
494a52a04b rename 2019-05-31 19:33:02 +03:00
Shlomi Fish
aa1907a567 add the write tags methods. 2019-05-31 19:33:02 +03:00
Shlomi Fish
7a12c8b21f add writeEmptyTag. 2019-05-31 19:33:02 +03:00
Shlomi Fish
44413c9f0b start writing the kpat emitter. 2019-05-31 19:33:02 +03:00
Shlomi Fish
c12be2eaed optimization 2019-05-31 19:28:27 +03:00
Shlomi Fish
b6da50d20f Extract a function or class to step away from God Object.
See:

* https://en.wikipedia.org/wiki/God_object

* https://www.c-sharpcorner.com/article/god-object-a-code-smell/ .

This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2019-05-31 19:23:27 +03:00
Shlomi Fish
75ffea5005 Extract a method or a function.
This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2019-05-31 18:32:47 +03:00
Shlomi Fish
a073d20af7 Refactoring / code cleanup.
See:

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2019-05-31 18:09:57 +03:00
Shlomi Fish
9acc97be8a Refactoring / code cleanup.
See:

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2019-05-31 17:22:49 +03:00
Shlomi Fish
26e5aeb045 Rename variable/s to make them more descriptive.
dir is a py builtin.
2019-05-31 16:42:57 +03:00
Shlomi Fish
32411ab0ec Refactoring. 2019-05-31 16:32:24 +03:00
Shlomi Fish
efddc917b2 Extract a method or a function.
This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2019-05-31 16:03:22 +03:00
Shlomi Fish
2bec58be2d Fix next deal / Ctrl+N for ms deals. 2019-05-23 19:10:57 +03:00
Shlomi Fish
74441a1746 Convert functionality to pysol-cards mod. 2019-05-23 17:26:27 +03:00
Shlomi Fish
4853b2dc5f pickle backcompat. 2019-05-16 18:46:05 +03:00
Shlomi Fish
76804c6d76 flake8 2019-04-30 18:25:01 +03:00
Shlomi Fish
9142b90cb2 Refactoring / code cleanup.
Remove the unused "Comments" class.

See:

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2019-04-30 17:49:36 +03:00
Shlomi Fish
ea73eb32a3 refactoring 2019-04-30 17:40:18 +03:00
Shlomi Fish
824407b136 Extract a common module/library/header.
This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2019-04-30 17:14:57 +03:00
Shlomi Fish
9af86cddfb Extract a common module/library/header.
This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2019-04-29 15:14:36 +03:00
Shlomi Fish
90323173a7 Extract a common module/library/header.
This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2019-04-29 15:08:04 +03:00
Shlomi Fish
9e148b88fe implement the --deal command line param.
It implements a starting deal seed/index/number.
2019-04-29 14:51:01 +03:00
Shlomi Fish
da256a30b0 use normal print to avoid b"...". 2019-04-29 14:25:04 +03:00
Shlomi Fish
cb25f39136 abort on invalid command line game. 2019-04-29 14:24:21 +03:00
Shlomi Fish
918f177acc prepare for v2.6.4 release. 2019-04-25 21:23:56 +03:00
Roderik Ploszek
9bf8f475bb Fix Three Peaks scoring
Score is correctly updated after moving a card to the waste stack or
after winning a game. Double counting is prevented by the score_counted
variable.

see https://github.com/shlomif/PySolFC/issues/111
2019-04-22 09:28:18 +02:00
Shlomi Fish
d3561e0e77 merge differences between */toolbar.py.
Refactoring.
2019-04-08 18:34:27 +03:00
Shlomi Fish
0696750457 bump version to 2.6.3 2019-04-07 13:40:31 +03:00
Shlomi Fish
1d3ffc4e1d Try fixing issue #108 - compat with pillow 6.0
See https://github.com/shlomif/PySolFC/issues/108 .
2019-04-05 17:37:04 +03:00
Shlomi Fish
2e67242e92 Fix the window size on startup.
See https://github.com/shlomif/PySolFC/issues/84 :

<<<

Yes, I can confirm that the "Save games geometry" option is present in
that build, and that it works! +1

The default startup window looks like this though (which is something
that should be addressed):

>>>
2019-04-05 16:26:55 +03:00
Shlomi Fish
48e24c2021 try fix save games geometry.
See https://github.com/shlomif/PySolFC/issues/84 .
2019-04-04 13:11:44 +03:00
Shlomi Fish
80252696c8 try restore Save game geometry on USE_PIL.
See https://github.com/shlomif/PySolFC/issues/84 .
2019-04-04 12:39:24 +03:00
Shlomi Fish
4deb3ebb58 bump the version to 2.6.2 2019-02-27 22:52:26 +02:00
Shlomi Fish
d3b1674a47 Fix spider illegal moves canMove bug.
See https://sourceforge.net/p/pysolfc/bugs/36/ . TODO: add tests.
2019-02-19 19:45:51 +02:00
Shlomi Fish
91e5cdafa3 Fix the indentation.
See http://perl-begin.org/tutorials/bad-elements/#no-indentation .
2019-02-19 17:14:17 +02:00
Shlomi Fish
490f8f2f25 bump the version 2019-02-16 22:01:05 +02:00
Shlomi Fish
8a93f4ba13 Try to fix issue#100.
site module is not present.
2019-02-16 21:58:24 +02:00