Shlomi Fish
b3f79c9df8
Extract a function or class to step away from God Object.
...
See:
* https://en.wikipedia.org/wiki/God_object
* https://www.c-sharpcorner.com/article/god-object-a-code-smell/ .
This is Refactoring / code cleanup.
See:
* https://refactoring.com/catalog/extractMethod.html
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-12-30 20:38:25 +02:00
Shlomi Fish
fab74e9a4b
Extract a function or class to step away from God Object.
...
See:
* https://en.wikipedia.org/wiki/God_object
* https://www.c-sharpcorner.com/article/god-object-a-code-smell/ .
This is Refactoring / code cleanup.
See:
* https://refactoring.com/catalog/extractMethod.html
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-12-29 11:37:13 +02:00
Shlomi Fish
b250a567ae
avoid leftover py2 test files.
2019-12-29 11:13:52 +02:00
Shlomi Fish
0f662fdb12
Extract a function or class to step away from God Object.
...
See:
* https://en.wikipedia.org/wiki/God_object
* https://www.c-sharpcorner.com/article/god-object-a-code-smell/ .
This is Refactoring / code cleanup.
See:
* https://refactoring.com/catalog/extractMethod.html
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-12-29 11:08:56 +02:00
Shlomi Fish
c017d36bd5
appveyor fix #1 - temply invalidate caches
2019-12-27 21:46:17 +02:00
Topi Miettinen
d2964fad0a
Skiz help: fix typo
...
decending -> descending
2019-12-22 10:57:02 +02:00
Shlomi Fish
d7c87ca066
move functionality to pysol-cards PyPI module
2019-12-10 12:14:31 +02:00
Shlomi Fish
0961401105
fix tests
2019-11-13 08:39:59 +02:00
Topi Miettinen
e65c236dc9
Describe order of Ganjifa suits
...
Help for Dashavatara Ganjifa games refer to general Ganjifa help for
order of suits, but it was actually missing.
2019-10-27 12:44:49 +02:00
lufebe16
063c35db0d
Android build script adaptations.
2019-10-15 16:17:31 +02:00
lufebe16
70fedf618a
Added android permission request dialog
2019-10-14 19:58:22 +02:00
lufebe16
64cd1b73f2
Double tap added to cardselection (kivy toolkit)
...
- fixes issue #117
2019-10-02 11:35:56 +02:00
lufebe16
92f2d5f602
fixed2: allow game restore to accept older storage format.
2019-09-27 11:24:03 +02:00
lb@lb7520
97267e9a77
fixed: restore game
2019-09-26 12:21:58 +02:00
lb@lb7520
263858838f
language selection
...
- option 'language' added to option section 'general'
- language selection code in kivy menubar
- mygettext refactored
- translations (german) updated
2019-09-25 19:46:17 +02:00
lb@lb7520
4a297ee434
german translations (revised)
2019-09-24 16:48:41 +02:00
lb@lb7520
6cc0ff767c
german translations (mainly kivy/android related)
...
- updated kivy/android files
- executed 'make pot' to update message-ids
- german translations added
2019-09-23 19:55:50 +02:00
Juhani Numminen
ef0c45841d
Update translations after string changes
2019-08-31 13:22:21 +03:00
Juhani Numminen
65b86f2d1d
Improve internationalization
...
- More strings marked for translation
- Used format strings instead of concatinating fragments
- Removed space before '?' or '!' from sentences in English
Following the GNU gettext guidelines at
https://www.gnu.org/software/gettext/manual/gettext.html#Preparing-Strings
2019-08-31 13:22:21 +03:00
Shlomi Fish
34609fc9d2
Extract a common class/struct.
...
This is Refactoring / code cleanup.
See:
* https://en.wikipedia.org/wiki/God_object
* https://en.wikipedia.org/wiki/Extract_class
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-08-29 16:55:47 +03:00
Shlomi Fish
5bc41f5614
Add more items to "how you can contribute".
2019-08-29 15:54:34 +03:00
Shlomi Fish
a472160ca7
Extract a common class/struct.
...
This is Refactoring / code cleanup.
See:
* https://en.wikipedia.org/wiki/God_object
* https://en.wikipedia.org/wiki/Extract_class
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-08-27 21:32:20 +03:00
Juhani Numminen
a5d584371e
Refactor and comment locale_dir selection
2019-08-20 16:23:05 +03:00
Juhani Numminen
93c9535216
Detect LANG for gettext on android
2019-08-20 11:54:49 +03:00
Juhani Numminen
8bef9848a5
setup*.py: Install locale/ also on macOS and Windows
2019-08-20 11:54:49 +03:00
lb@lb7520
bd4be45118
Changes to apk build procedures used with fdroid build.
...
- mkp4a.init: 1 optional parameter
- mkp4a.unsigned: 2 paramters (sdk and ndk paths)
- mkp4a.preload: new helper script
2019-08-20 10:04:55 +02:00
Shlomi Fish
a8dbceec93
valid xhtml5
2019-08-16 16:30:39 +03:00
Shlomi Fish
b5224318ae
Fix the website build.
...
See https://github.com/shlomif/pysolfc-website/ - do not remove.
2019-08-16 15:42:49 +03:00
Shlomi Fish
cbae7ebbf5
gnumakefile cleanup.
2019-08-16 15:29:09 +03:00
Shlomi Fish
052318895e
Update .gitignore: add generated files or remove old.
2019-08-16 15:08:31 +03:00
Shlomi Fish
7bbacfb97e
Extract a method or a function.
...
This is Refactoring / code cleanup.
See:
* https://refactoring.com/catalog/extractMethod.html
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-08-14 20:49:03 +03:00
Shlomi Fish
0ffcc12afc
Extract a common class/struct.
...
This is Refactoring / code cleanup.
See:
* https://en.wikipedia.org/wiki/God_object
* https://en.wikipedia.org/wiki/Extract_class
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-08-14 19:42:24 +03:00
Shlomi Fish
9b0b862406
Extract a common class/struct.
...
This is Refactoring / code cleanup.
See:
* https://en.wikipedia.org/wiki/God_object
* https://en.wikipedia.org/wiki/Extract_class
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-08-14 18:25:34 +03:00
Shlomi Fish
23843dc2a8
Extract a common class/struct.
...
This is Refactoring / code cleanup.
See:
* https://en.wikipedia.org/wiki/God_object
* https://en.wikipedia.org/wiki/Extract_class
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-08-14 17:59:27 +03:00
lb@lb7520
18febbe240
cardconv updated.
...
png images converted from gifs by IM resulted in an indexed png format. This
lead to Problems with tranparency, especially with ganijfa and hanafuda
cardsets. To circumvent these problems IM had to be advised to produce
32 bit mode rgba format.
affects android apk build process only.
2019-08-13 10:00:49 +02:00
lb@lb520
5b75c1b413
Further corrections to python3 / android. Card images format has been changed to png. And a bugfix.
2019-08-12 09:50:38 +02:00
lb@lb520
81da718007
additional deletes in mkp4a.init to allow apk builds out of the repo
...
fix for a gradle bug (in mkp4a.common)
2019-08-09 11:16:31 +02:00
Juhani Numminen
fdebf13171
android: adapt to python3.
...
android: Install p4a using pip
Add 'set -e' to sh scripts, they must stop upon any error
README.md: kivy does not specifically require python2
android: Overhaul initialization scripts
android: Simplify apk build scripts by using the 'common' file
Merge the scripts cardconv and cardsetsgiftobmp
android: Fix startup script shebang to python3
android: Simplify mkkeystore and ignore the keystore file
android: Fix up debian prerequisites
The package cython (as opposed to cython3) even caused me to produce
an apk that did not start (TypeError: must be str, not bytes).
Android SDK requires java8; install and set as the default.
The build processes complained about lld and libtinfo5; added in.
mercurial (or hg) is seemingly unused.
The pip pcakges were needed by android/initsdk.py which is gone.
android: Ensure that the html files are built
2019-08-08 19:12:44 +03:00
Shlomi Fish
15365f6267
moved functionality to pysol-cards.py
2019-08-08 18:44:49 +03:00
Shlomi Fish
c71c2fa07a
Fix the 'picturegallery' game.
...
See https://github.com/shlomif/PySolFC/issues/140 . Thanks to
@scottfurry for testing.
2019-08-07 12:28:29 +03:00
Juhani Numminen
836eb54008
Add an error message to pysol_cards version check
2019-08-06 20:07:30 +03:00
Shlomi Fish
fd5bf10ddd
moved functionality to pysol-cards.py
2019-08-04 18:47:19 +03:00
Shlomi Fish
0082962a93
Extract a common class/struct.
...
This is Refactoring / code cleanup.
See:
* https://en.wikipedia.org/wiki/God_object
* https://en.wikipedia.org/wiki/Extract_class
* https://en.wikipedia.org/wiki/Code_refactoring
* https://www.refactoring.com/
* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/
Some small optimisations may have slipped in as well.
2019-07-31 16:10:28 +03:00
Shlomi Fish
4d61d73f3a
consolidate diffs
2019-07-30 12:37:22 +03:00
Shlomi Fish
6b228291cc
update to latest pypi ver
2019-07-30 12:36:31 +03:00
Juhani Numminen
52348a4daa
travis: Simplify pip install step
2019-07-28 22:28:56 +03:00
Juhani Numminen
d1e1e436a1
travis: Change language from python to generic
...
Travis's python virtualenv setup does not help too much in our case
because we use both python2 and python3 while travis will setup the
virtualenv for only one at a time.
2019-07-28 22:28:56 +03:00
Juhani Numminen
76882c9dd1
travis: linux: Use alternative way to install deps, apt addon is not working anymore?!
...
Strip down some dependencies:
- libperl-dev is not used.
- perl will come with cpanminus.
- make is installed in Travis' ubuntu image anyway.
- python3 will follow from the python3-* modules.
- Explicitly mention python-pip.
2019-07-28 22:28:56 +03:00
Juhani Numminen
e80c3637dd
travis: osx: Do not set CPPFLAGS etc, nothing will be compiled
2019-07-28 22:28:56 +03:00
Juhani Numminen
edf3470dfe
travis: Change Ubuntu 14.04 to 18.04
2019-07-28 22:28:56 +03:00