From 059e60c3cae02a7fb119fc7272846efdfdab69c5 Mon Sep 17 00:00:00 2001 From: Eduardo Gurgel Date: Thu, 30 Jan 2014 11:20:59 -0300 Subject: [PATCH] Use 301 instead of 307 --- lib/httparrot/redirect_handler.ex | 2 +- test/redirect_handler_test.exs | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/httparrot/redirect_handler.ex b/lib/httparrot/redirect_handler.ex index 8fac32a..1988e22 100644 --- a/lib/httparrot/redirect_handler.ex +++ b/lib/httparrot/redirect_handler.ex @@ -24,7 +24,7 @@ defmodule HTTParrot.RedirectHandler do def resource_exists(req, state), do: {false, req, state} def previously_existed(req, state), do: {true, req, state} - def moved_temporarily(req, n) do + def moved_permanently(req, n) do {host_url, req} = :cowboy_req.host_url(req) url = if n > 1, do: "/redirect/#{n-1}", else: "/get" {{true, host_url <> url}, req, nil} diff --git a/test/redirect_handler_test.exs b/test/redirect_handler_test.exs index 634958a..e04a627 100644 --- a/test/redirect_handler_test.exs +++ b/test/redirect_handler_test.exs @@ -35,18 +35,18 @@ defmodule HTTParrot.RedirectHandlerTest do assert validate :cowboy_req end - test "moved_temporarily returns 'redirect/n-1' if n > 1" do + test "moved_permanently returns 'redirect/n-1' if n > 1" do expect(:cowboy_req, :host_url, 1, {"host", :req2}) - assert moved_temporarily(:req1, 4) == {{true, "host/redirect/3"}, :req2, nil} + assert moved_permanently(:req1, 4) == {{true, "host/redirect/3"}, :req2, nil} assert validate :cowboy_req end - test "moved_temporarily returns '/get' if n = 1" do + test "moved_permanently returns '/get' if n = 1" do expect(:cowboy_req, :host_url, 1, {"host", :req2}) - assert moved_temporarily(:req1, 1) == {{true, "host/get"}, :req2, nil} + assert moved_permanently(:req1, 1) == {{true, "host/get"}, :req2, nil} assert validate :cowboy_req end