anthonycicc/PySolFC
1
0
Fork 0
mirror of https://github.com/shlomif/PySolFC.git synced 2025-04-15 02:54:09 -04:00
Code Releases Activity
1360 commits 57 branches 40 tags 259 MiB
Commit graph

1013 commits

Author SHA1 Message Date
lufebe16
9169297801 Updates kivy version: 
- added support for right mouse button (desktop only)
- corrected a problem with virtualenv in mkp4a.init
 2020-05-06 15:11:24 +03:00
Shlomi Fish
3649a52ab2 SHOULD_PUT_bye_for_now_FIRST = False 
To avoid complaints about non random music.
 2020-05-06 15:11:24 +03:00
Juhani Numminen
3f660b25a0 Import ttk from standard library, drop local copy 2020-05-06 15:11:24 +03:00
Juhani Numminen
ca93af4897 Fix whitespace in pyramid.py 2020-05-06 15:11:24 +03:00
lufebe16
2fea665242 Corrections on game 'pyramid' 
- For TypeError reported with #147. (clickhandler failed to return a value)
- For index out of range (in pyramid.y)
 2020-05-06 15:11:24 +03:00
Juhani Numminen
d0ff5494d5 Fix 'TclError: unknown option' for tk 
Partly reverts commit b9a46ecf35
 2020-05-06 15:11:24 +03:00
Juhani Numminen
3793d8392e Do not catch exceptions too broadly in mainloop 
StopIteration seems to be the expected way to stop, at least
for the tk and tile interfaces.
 2020-05-06 15:11:24 +03:00
Juhani Numminen
0fd5e40b54 Fix menu colors on macOS with dark menu bar 
Widget colors and all scrollbars look just fine without these lines
despite the comments.
 2020-05-06 15:11:24 +03:00
Shlomi Fish
2c16d5773d fix a crash on "open game" 2020-02-09 11:42:44 +02:00
Shlomi Fish
eb5e97acc7 Refactoring / code cleanup. 
Use a frozenset()-like list.

See:

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
 2020-02-09 11:39:40 +02:00
Shlomi Fish
8078db9abc fix load/save 2020-02-09 11:39:40 +02:00
Shlomi Fish
d90bbdab2e Add 13 column Bisley - thanks to qunka. 
See:

* https://github.com/shlomif/PySolFC/issues/148

* https://gist.github.com/qunka/3adac1878b481eb419ff6f3e1726add5

Thanks to https://github.com/qunka .
 2020-02-09 11:39:40 +02:00
Shlomi Fish
70012407b0 Extract a function or class to step away from God Object. 
See:

* https://en.wikipedia.org/wiki/God_object

* https://www.c-sharpcorner.com/article/god-object-a-code-smell/ .

This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
 2020-02-09 11:39:40 +02:00
Shlomi Fish
93d8c2a564 Extract a function or class to step away from God Object. 
See:

* https://en.wikipedia.org/wiki/God_object

* https://www.c-sharpcorner.com/article/god-object-a-code-smell/ .

This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
 2020-02-09 11:39:40 +02:00
Shlomi Fish
4e7a01517a Extract a function or class to step away from God Object. 
See:

* https://en.wikipedia.org/wiki/God_object

* https://www.c-sharpcorner.com/article/god-object-a-code-smell/ .

This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
 2020-02-09 11:39:40 +02:00
Shlomi Fish
2bf9b249cc move functionality to pysol-cards PyPI module 2020-02-09 11:39:40 +02:00
Shlomi Fish
1feb099be0 fix tests 2020-02-09 11:39:40 +02:00
lufebe16
5119b5a161 Added android permission request dialog 2020-02-09 11:39:40 +02:00
lufebe16
de2d9d5eae Double tap added to cardselection (kivy toolkit) 
- fixes issue #117
 2020-02-09 11:39:40 +02:00
lufebe16
ad0512d333 fixed2: allow game restore to accept older storage format. 2020-02-09 11:39:40 +02:00
lb@lb7520
62a754a0ee fixed: restore game 2020-02-09 11:39:40 +02:00
lb@lb7520
1bc1dd25c5 language selection 
- option 'language' added to option section 'general'
- language selection code in kivy menubar
- mygettext refactored
- translations (german) updated
 2020-02-09 11:39:40 +02:00
lb@lb7520
58bf92b87a german translations (revised) 2020-02-09 11:39:40 +02:00
lb@lb7520
d0f409db80 german translations (mainly kivy/android related) 
- updated kivy/android files
- executed 'make pot' to update message-ids
- german translations added
 2020-02-09 11:39:40 +02:00
Juhani Numminen
2f93667fc6 Improve internationalization 
- More strings marked for translation
- Used format strings instead of concatinating fragments
- Removed space before '?' or '!' from sentences in English

Following the GNU gettext guidelines at
https://www.gnu.org/software/gettext/manual/gettext.html#Preparing-Strings
 2020-02-09 11:39:40 +02:00
Shlomi Fish
18e6ab96be Extract a common class/struct. 
This is Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/God_object

* https://en.wikipedia.org/wiki/Extract_class

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
 2020-02-09 11:39:40 +02:00
Shlomi Fish
d8367a140a Extract a common class/struct. 
This is Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/God_object

* https://en.wikipedia.org/wiki/Extract_class

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
 2020-02-09 11:39:40 +02:00
Juhani Numminen
7a7874fc47 Refactor and comment locale_dir selection 2020-02-09 11:39:40 +02:00
Juhani Numminen
6ea2bba758 Detect LANG for gettext on android 2020-02-09 11:39:40 +02:00
Shlomi Fish
39a4978357 Extract a method or a function. 
This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
 2020-02-09 11:39:40 +02:00
Shlomi Fish
6ddacc7d27 Extract a common class/struct. 
This is Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/God_object

* https://en.wikipedia.org/wiki/Extract_class

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
 2020-02-09 11:39:40 +02:00
Shlomi Fish
08a1a9b872 Extract a common class/struct. 
This is Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/God_object

* https://en.wikipedia.org/wiki/Extract_class

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
 2020-02-09 11:39:40 +02:00
Shlomi Fish
493e044122 Extract a common class/struct. 
This is Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/God_object

* https://en.wikipedia.org/wiki/Extract_class

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
 2020-02-09 11:39:39 +02:00
lb@lb520
f73c032b41 Further corrections to python3 / android. Card images format has been changed to png. And a bugfix. 2020-02-09 11:39:39 +02:00
Shlomi Fish
575b4b1923 moved functionality to pysol-cards.py 2020-02-09 11:39:39 +02:00
Shlomi Fish
72c2276f94 Fix the 'picturegallery' game. 
See https://github.com/shlomif/PySolFC/issues/140 . Thanks to
@scottfurry for testing.
 2020-02-09 11:39:39 +02:00
Juhani Numminen
989b566090 Add an error message to pysol_cards version check 2020-02-09 11:39:39 +02:00
Shlomi Fish
abdac68586 moved functionality to pysol-cards.py 2020-02-09 11:39:39 +02:00
Shlomi Fish
35d6c0e9b4 Extract a common class/struct. 
This is Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/God_object

* https://en.wikipedia.org/wiki/Extract_class

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
 2020-02-09 11:39:39 +02:00
Shlomi Fish
3ff955be53 consolidate diffs 2020-02-09 11:39:39 +02:00
Shlomi Fish
0e692eb511 update to latest pypi ver 2020-02-09 11:39:39 +02:00
Shlomi Fish
4726d91f66 fix flake8 tests 2020-02-09 11:39:39 +02:00
Frédéric Brière
618195bb8e Define canMoveCards() for Hanafuda sequence stacks 
Any stack of Hanafuda cards is always deemed movable, even if it is out
of sequence.  The effect can easily be seen a game such as Firecracker,
where:

 - Any stack can be dragged as a whole (but not released)
 - "Highlight piles" will highlight everything
 - Asking for a hint will ignore most valid moves

This is due to Hanafuda_SequenceStack lacking a canMoveCards() method.
 2020-02-09 11:39:39 +02:00
Juhani Numminen
09a5df8439 Remove checks for individual cardsets' COPYRIGHT files 
It is not strictly necessary to check the presence of the COPYRIGHT file
since pysollib/{tile,tk}/selectcardset.py will work even if it's missing.

In the Debian package, individual COPYRIGHT files are missing as all license
information should be in one file anyway, /usr/share/doc/pysolfc/copyright.

Thanks to Bernhard Reiter who originally wrote this patch:
https://salsa.debian.org/games-team/pysolfc/blob/87493fb/debian/patches/remove_checks_for_copyright_files
 2020-02-09 11:39:39 +02:00
Juhani Numminen
e1a320c837 Improve Filesystem Hierarchy Standard compliance 
These are actually for binaries, not data:
/usr/games       "Games and educational binaries"
/usr/local/games "Local game binaries"

The directories for the data:
/usr/share/games "Static data files for /usr/games"

"The requirements for the contents of [/usr/local/share] are the same as for
/usr/share."

Quoting https://refspecs.linuxfoundation.org/FHS_3.0/fhs-3.0.html
 2020-02-09 11:39:39 +02:00
Shlomi Fish
c524900e69 consolidate diffs 2020-02-09 11:39:39 +02:00
Shlomi Fish
b3f6232dd7 Extract a common class/struct. 
This is Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/God_object

* https://en.wikipedia.org/wiki/Extract_class

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
 2020-02-09 11:39:39 +02:00
Shlomi Fish
f3d3517160 add missing attribute. 
See https://github.com/shlomif/PySolFC/issues/129 .
 2020-02-09 11:39:39 +02:00
Shlomi Fish
a7b8921695 minimal ver of pysol_cards. 
See https://github.com/shlomif/PySolFC/issues/128 .
 2020-02-09 11:39:39 +02:00
Shlomi Fish
b2a9fde2f5 moved functionality to pysol-cards.py 2020-02-09 11:39:39 +02:00