1
0
Fork 0
mirror of https://github.com/shlomif/PySolFC.git synced 2025-04-05 00:02:29 -04:00
Commit graph

1350 commits

Author SHA1 Message Date
Juhani Numminen
0fd5e40b54 Fix menu colors on macOS with dark menu bar
Widget colors and all scrollbars look just fine without these lines
despite the comments.
2020-05-06 15:11:24 +03:00
Shlomi Fish
2c16d5773d fix a crash on "open game" 2020-02-09 11:42:44 +02:00
Shlomi Fish
eb5e97acc7 Refactoring / code cleanup.
Use a frozenset()-like list.

See:

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2020-02-09 11:39:40 +02:00
Shlomi Fish
8078db9abc fix load/save 2020-02-09 11:39:40 +02:00
Juhani Numminen
74016ff224 README: Change venv to reference PKGTREE and list more pre-requisites (#149) 2020-02-09 11:39:40 +02:00
Juhani Numminen
f96ceb57a0 install-pysolfc.sh: Use bash array for holding a program name and arguments
The previous scalar variable with quoted "$PIP" caused a "command not found"
error because that erroneously put prog name and arguments in a single token.
2020-02-09 11:39:40 +02:00
Shlomi Fish
d90bbdab2e Add 13 column Bisley - thanks to qunka.
See:

* https://github.com/shlomif/PySolFC/issues/148

* https://gist.github.com/qunka/3adac1878b481eb419ff6f3e1726add5

Thanks to https://github.com/qunka .
2020-02-09 11:39:40 +02:00
Shlomi Fish
70012407b0 Extract a function or class to step away from God Object.
See:

* https://en.wikipedia.org/wiki/God_object

* https://www.c-sharpcorner.com/article/god-object-a-code-smell/ .

This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2020-02-09 11:39:40 +02:00
Shlomi Fish
93d8c2a564 Extract a function or class to step away from God Object.
See:

* https://en.wikipedia.org/wiki/God_object

* https://www.c-sharpcorner.com/article/god-object-a-code-smell/ .

This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2020-02-09 11:39:40 +02:00
Shlomi Fish
85545dd67c avoid leftover py2 test files. 2020-02-09 11:39:40 +02:00
Shlomi Fish
4e7a01517a Extract a function or class to step away from God Object.
See:

* https://en.wikipedia.org/wiki/God_object

* https://www.c-sharpcorner.com/article/god-object-a-code-smell/ .

This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2020-02-09 11:39:40 +02:00
Shlomi Fish
b4947cccce appveyor fix #1 - temply invalidate caches 2020-02-09 11:39:40 +02:00
Topi Miettinen
879709d682 Skiz help: fix typo
decending -> descending
2020-02-09 11:39:40 +02:00
Shlomi Fish
2bf9b249cc move functionality to pysol-cards PyPI module 2020-02-09 11:39:40 +02:00
Shlomi Fish
1feb099be0 fix tests 2020-02-09 11:39:40 +02:00
Topi Miettinen
4c8c511626 Describe order of Ganjifa suits
Help for Dashavatara Ganjifa games refer to general Ganjifa help for
order of suits, but it was actually missing.
2020-02-09 11:39:40 +02:00
lufebe16
8f618a6a29 Android build script adaptations. 2020-02-09 11:39:40 +02:00
lufebe16
5119b5a161 Added android permission request dialog 2020-02-09 11:39:40 +02:00
lufebe16
de2d9d5eae Double tap added to cardselection (kivy toolkit)
- fixes issue #117
2020-02-09 11:39:40 +02:00
lufebe16
ad0512d333 fixed2: allow game restore to accept older storage format. 2020-02-09 11:39:40 +02:00
lb@lb7520
62a754a0ee fixed: restore game 2020-02-09 11:39:40 +02:00
lb@lb7520
1bc1dd25c5 language selection
- option 'language' added to option section 'general'
- language selection code in kivy menubar
- mygettext refactored
- translations (german) updated
2020-02-09 11:39:40 +02:00
lb@lb7520
58bf92b87a german translations (revised) 2020-02-09 11:39:40 +02:00
lb@lb7520
d0f409db80 german translations (mainly kivy/android related)
- updated kivy/android files
- executed 'make pot' to update message-ids
- german translations added
2020-02-09 11:39:40 +02:00
Juhani Numminen
f50604354c Update translations after string changes 2020-02-09 11:39:40 +02:00
Juhani Numminen
2f93667fc6 Improve internationalization
- More strings marked for translation
- Used format strings instead of concatinating fragments
- Removed space before '?' or '!' from sentences in English

Following the GNU gettext guidelines at
https://www.gnu.org/software/gettext/manual/gettext.html#Preparing-Strings
2020-02-09 11:39:40 +02:00
Shlomi Fish
18e6ab96be Extract a common class/struct.
This is Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/God_object

* https://en.wikipedia.org/wiki/Extract_class

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2020-02-09 11:39:40 +02:00
Shlomi Fish
4c331d32bd Add more items to "how you can contribute". 2020-02-09 11:39:40 +02:00
Shlomi Fish
d8367a140a Extract a common class/struct.
This is Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/God_object

* https://en.wikipedia.org/wiki/Extract_class

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2020-02-09 11:39:40 +02:00
Juhani Numminen
7a7874fc47 Refactor and comment locale_dir selection 2020-02-09 11:39:40 +02:00
Juhani Numminen
6ea2bba758 Detect LANG for gettext on android 2020-02-09 11:39:40 +02:00
Juhani Numminen
ceb6df5548 setup*.py: Install locale/ also on macOS and Windows 2020-02-09 11:39:40 +02:00
lb@lb7520
e9ee79bb46 Changes to apk build procedures used with fdroid build.
- mkp4a.init: 1 optional parameter
- mkp4a.unsigned: 2 paramters (sdk and ndk paths)
- mkp4a.preload: new helper script
2020-02-09 11:39:40 +02:00
Shlomi Fish
0c686267b3 valid xhtml5 2020-02-09 11:39:40 +02:00
Shlomi Fish
195890894a Fix the website build.
See https://github.com/shlomif/pysolfc-website/ - do not remove.
2020-02-09 11:39:40 +02:00
Shlomi Fish
6a5287c0b8 gnumakefile cleanup. 2020-02-09 11:39:40 +02:00
Shlomi Fish
05cb36a41f Update .gitignore: add generated files or remove old. 2020-02-09 11:39:40 +02:00
Shlomi Fish
39a4978357 Extract a method or a function.
This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2020-02-09 11:39:40 +02:00
Shlomi Fish
6ddacc7d27 Extract a common class/struct.
This is Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/God_object

* https://en.wikipedia.org/wiki/Extract_class

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2020-02-09 11:39:40 +02:00
Shlomi Fish
08a1a9b872 Extract a common class/struct.
This is Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/God_object

* https://en.wikipedia.org/wiki/Extract_class

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2020-02-09 11:39:40 +02:00
Shlomi Fish
493e044122 Extract a common class/struct.
This is Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/God_object

* https://en.wikipedia.org/wiki/Extract_class

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2020-02-09 11:39:39 +02:00
lb@lb7520
efff5f56ff cardconv updated.
png images converted from gifs by IM resulted in an indexed png format. This
lead to Problems with tranparency, especially with ganijfa and hanafuda
cardsets. To circumvent these problems IM had to be advised to produce
32 bit mode rgba format.
affects android apk build process only.
2020-02-09 11:39:39 +02:00
lb@lb520
f73c032b41 Further corrections to python3 / android. Card images format has been changed to png. And a bugfix. 2020-02-09 11:39:39 +02:00
lb@lb520
3396bcd0ef additional deletes in mkp4a.init to allow apk builds out of the repo
fix for a gradle bug (in mkp4a.common)
2020-02-09 11:39:39 +02:00
Juhani Numminen
50a4c06e1c android: adapt to python3.
android: Install p4a using pip
Add 'set -e' to sh scripts, they must stop upon any error
README.md: kivy does not specifically require python2
android: Overhaul initialization scripts
android: Simplify apk build scripts by using the 'common' file
Merge the scripts cardconv and cardsetsgiftobmp
android: Fix startup script shebang to python3
android: Simplify mkkeystore and ignore the keystore file
android: Fix up debian prerequisites

The package cython (as opposed to cython3) even caused me to produce
an apk that did not start (TypeError: must be str, not bytes).

Android SDK requires java8; install and set as the default.

The build processes complained about lld and libtinfo5; added in.

mercurial (or hg) is seemingly unused.

The pip pcakges were needed by android/initsdk.py which is gone.

android: Ensure that the html files are built
2020-02-09 11:39:39 +02:00
Shlomi Fish
575b4b1923 moved functionality to pysol-cards.py 2020-02-09 11:39:39 +02:00
Shlomi Fish
72c2276f94 Fix the 'picturegallery' game.
See https://github.com/shlomif/PySolFC/issues/140 . Thanks to
@scottfurry for testing.
2020-02-09 11:39:39 +02:00
Juhani Numminen
989b566090 Add an error message to pysol_cards version check 2020-02-09 11:39:39 +02:00
Shlomi Fish
abdac68586 moved functionality to pysol-cards.py 2020-02-09 11:39:39 +02:00
Shlomi Fish
35d6c0e9b4 Extract a common class/struct.
This is Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/God_object

* https://en.wikipedia.org/wiki/Extract_class

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
2020-02-09 11:39:39 +02:00