Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.

pysollib/actions.py

@@ -518,15 +518,12 @@ class PysolMenubar(PysolMenubarTk):
                     text += os.linesep
                 enc = locale.getpreferredencoding()
                 try:
-                    fd = open(fn, 'a')
+                    open(fn, 'a').write(text.encode(enc, 'replace'))
-                    fd.write(text.encode(enc, 'replace'))
                 except Exception as err:
                     d = MfxExceptionDialog(
                         self.top, err,
                         text=_("Error while writing to file"))
                 else:
-                    if fd:
-                        fd.close()
                     d = MfxMessageDialog(
                         self.top, title=TITLE+_(" Info"), bitmap="info",
                         text=_("Comments were appended to\n\n") + fn)
@@ -537,7 +534,6 @@ class PysolMenubar(PysolMenubarTk):
     #
 
     def _mStatsSave(self, player, filename, write_method):
-        file = None
         if player is None:
             text = _("Demo statistics")
             filename = filename + "_demo"
@@ -546,17 +542,12 @@ class PysolMenubar(PysolMenubarTk):
         filename = os.path.join(self.app.dn.config, filename + ".txt")
         filename = os.path.normpath(filename)
         try:
-            file = open(filename, "a")
+            a = FileStatsFormatter(self.app, open(filename, "a"))
-            a = FileStatsFormatter(self.app, file)
             write_method(a, player)
         except EnvironmentError as ex:
-            if file:
-                file.close()
             MfxExceptionDialog(self.top, ex,
                                text=_("Error while writing to file"))
         else:
-            if file:
-                file.close()
             MfxMessageDialog(
                 self.top, title=TITLE+_(" Info"), bitmap="info",
                 text=text + _(" were appended to\n\n") + filename)

pysollib/app.py

@@ -1059,13 +1059,8 @@ Please select a %s type %s.
 
     # read & parse a cardset config.txt file - see class Cardset in resource.py
     def _readCardsetConfig(self, dirname, filename):
-        f = None
+        with open(filename, "r") as f:
-        try:
-            f = open(filename, "r")
             lines = f.readlines()
-        finally:
-            if f:
-                f.close()
         lines = [l.strip() for l in lines]
         if not lines[0].startswith("PySol"):
             return None
@@ -1309,7 +1304,7 @@ Please select a %s type %s.
     #
 
     def initResource(self, manager, dirs, ext_re, Resource_Class):
-        found, t = [], {}
+        found, t = [], set()
         for dirname in dirs:
             dirname = dirname.strip()
             if dirname:
@@ -1328,7 +1323,7 @@ Please select a %s type %s.
                     obj.name = n
                     key = n.lower()
                     if key not in t:
-                        t[key] = 1
+                        t.add(key)
                         found.append((n, obj))
             except EnvironmentError:
                 pass

pysollib/game.py

@@ -3165,14 +3165,9 @@ Please report this bug."""))
 
     def _loadGame(self, filename, app):
         game = None
-        f = None
+        with open(filename, "rb") as f:
-        try:
-            f = open(filename, "rb")
             game = self._undumpGame(Unpickler(f), app)
             game.gstats.loaded = game.gstats.loaded + 1
-        finally:
-            if f:
-                f.close()
         return game
 
     def _undumpGame(self, p, app):
@@ -3269,15 +3264,9 @@ in the current implementation.''') % version)
         return game
 
     def _saveGame(self, filename, protocol=-1):
-        f = None
+        if self.canSaveGame():
-        try:
+            with open(filename, "wb") as f:
-            if not self.canSaveGame():
+                self._dumpGame(Pickler(f, protocol))
-                raise Exception("Cannot save this game.")
-            f = open(filename, "wb")
-            self._dumpGame(Pickler(f, protocol))
-        finally:
-            if f:
-                f.close()
 
     def _dumpGame(self, p, bookmark=0):
         self.updateTime()

pysollib/wizardutil.py

@@ -399,11 +399,11 @@ def write_game(app, game=None):
         check_game = False
 
     # print '===>', fn
-    fd = open(fn, 'w')
+    with open(fn, 'w') as fd:
 
-    fd.write('''\
+        fd.write('''\
 ## -*- coding: utf-8 -*-
-## THIS FILE WAS GENERATED AUTOMATICALLY BY SOLITAIRE WIZARD
+## THIS FILE WAS GENERATED AUTOMATICALLY BY THE SOLITAIRE WIZARD
 ## DO NOT EDIT
 
 from pysollib.customgame import CustomGame, registerCustomGame
@@ -413,35 +413,34 @@ class MyCustomGame(CustomGame):
     SETTINGS = {
 ''')
 
-    for w in WizardWidgets:
+        for w in WizardWidgets:
-        if isinstance(w, six.string_types):
+            if isinstance(w, six.string_types):
-            continue
+                continue
-        v = w.variable.get()
+            v = w.variable.get()
-        if w.widget in ('menu', 'preset'):
+            if w.widget in ('menu', 'preset'):
-            v = w.translation_map[v]
+                v = w.translation_map[v]
-        if v == w.default:
+            if v == w.default:
-            # save only unique values
+                # save only unique values
-            continue
+                continue
-        if isinstance(v, int):
+            if isinstance(v, int):
-            fd.write("        '%s': %i,\n" % (w.var_name, v))
+                fd.write("        '%s': %i,\n" % (w.var_name, v))
-        else:
+            else:
-            if w.var_name == 'name':
+                if w.var_name == 'name':
-                # escape
+                    # escape
-                v = v.replace('\\', '\\\\')
+                    v = v.replace('\\', '\\\\')
-                v = v.replace("'", "\\'")
+                    v = v.replace("'", "\\'")
-                if isinstance(v, six.text_type):
+                    if isinstance(v, six.text_type):
-                    v = v.encode('utf-8')
+                        v = v.encode('utf-8')
-                if not v:
+                    if not v:
-                    v = 'Invalid Game Name'
+                        v = 'Invalid Game Name'
-            fd.write("        '%s': '%s',\n" % (w.var_name, v))
+                fd.write("        '%s': '%s',\n" % (w.var_name, v))
-    fd.write("        'gameid': %i,\n" % gameid)
+        fd.write("        'gameid': %i,\n" % gameid)
 
-    fd.write('''\
+        fd.write('''\
-        }
+            }
 
 registerCustomGame(MyCustomGame)
 ''')
-    fd.close()
 
     loadGame(mn, fn, check_game=check_game)