From 5e10f11ca5d49e2e9f014b6e516bf9c77bf95754 Mon Sep 17 00:00:00 2001
From: Shlomi Fish <shlomif@shlomifish.org>
Date: Thu, 6 Dec 2018 23:49:44 +0200
Subject: [PATCH] Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
---
 tests/lib/pysol_tests/scorpion_canMove.py | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/tests/lib/pysol_tests/scorpion_canMove.py b/tests/lib/pysol_tests/scorpion_canMove.py
index bb16c012..8039af9c 100644
--- a/tests/lib/pysol_tests/scorpion_canMove.py
+++ b/tests/lib/pysol_tests/scorpion_canMove.py
@@ -42,12 +42,8 @@ class MyTests(unittest.TestCase):
     def _calc_Scorpion_stack(self):
         g = MockGame()
         stack = Scorpion_RowStack(0, 0, g)
-        cards = [
-            AbstractCard(1000+r*100+s*10, 0, s, r, g)
-            for s, r in [(2, 5), (3, 7), (2, 7), (2, 0),
-                         (2, 3), (2, 4), (1, 4)]
-            ]
-        for c in cards:
+        for s, r in [(2, 5), (3, 7), (2, 7), (2, 0), (2, 3), (2, 4), (1, 4)]:
+            c = AbstractCard(1000+r*100+s*10, 0, s, r, g)
             c.face_up = True
             c.item = MockItem()
             stack.addCard(c)