anthonycicc/PySolFC
1
0
Fork 0
mirror of https://github.com/shlomif/PySolFC.git synced 2025-04-05 00:02:29 -04:00
Code Releases Activity

Extract a common class/struct.

Browse source 
This is Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/God_object

* https://en.wikipedia.org/wiki/Extract_class

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
This commit is contained in:
Shlomi Fish 2019-07-26 16:21:07 +03:00
parent 602f9ebc93
commit 3c93a19508
1 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
pysollib/game/__init__.py
View file

@ -350,6 +350,16 @@ class GameDrag(NewStruct):
shadows = attr.ib(factory=list) shadows = attr.ib(factory=list)
@attr.s
class GameTexts(NewStruct):
info = attr.ib(default=None)
help = attr.ib(default=None)
misc = attr.ib(default=None)
score = attr.ib(default=None)
base_rank = attr.ib(default=None)
list = attr.ib(factory=list)
class Game(object): class Game(object):
# for self.gstats.updated # for self.gstats.updated
U_PLAY = 0 U_PLAY = 0
@ -555,14 +565,7 @@ class Game(object):
if self.gstats.start_player is None: if self.gstats.start_player is None:
self.gstats.start_player = self.app.opt.player self.gstats.start_player = self.app.opt.player
# optional MfxCanvasText items # optional MfxCanvasText items
self.texts = Struct( self.texts = GameTexts()
info=None, # misc info text
help=None, # a static help text
misc=None, #
score=None, # for displaying the score
base_rank=None, # for displaying the base_rank
list=[], # list of texts (if we use many text)
)
# initial position of the texts # initial position of the texts
self.init_texts = Struct( self.init_texts = Struct(
info=None, # misc info text info=None, # misc info text