anthonycicc/PySolFC
1
0
Fork 0
mirror of https://github.com/shlomif/PySolFC.git synced 2025-04-05 00:02:29 -04:00
Code Releases Activity

Extract a method or a function.

Browse source 
This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
This commit is contained in:
Shlomi Fish 2018-12-06 23:41:49 +02:00
parent f95a6a5ba8
commit 2b2d23f958
1 changed files with 6 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
tests/lib/pysol_tests/scorpion_canMove.py
View file

@ -39,7 +39,7 @@ class Mock_S_Game:
class MyTests(unittest.TestCase): class MyTests(unittest.TestCase):
def test_canMoveCards(self): def _calc_Scorpion_stack(self):
g = MockGame() g = MockGame()
stack = Scorpion_RowStack(0, 0, g) stack = Scorpion_RowStack(0, 0, g)
cards = [ cards = [
@ -51,20 +51,14 @@ class MyTests(unittest.TestCase):
c.face_up = True c.face_up = True
c.item = MockItem() c.item = MockItem()
stack.addCard(c) stack.addCard(c)
return stack
def test_canMoveCards(self):
stack = self._calc_Scorpion_stack()
stack.canMoveCards(stack.cards[6:]) stack.canMoveCards(stack.cards[6:])
self.assertTrue(stack) self.assertTrue(stack)
def test_canMoveCards_non_top(self): def test_canMoveCards_non_top(self):
g = MockGame() stack = self._calc_Scorpion_stack()
stack = Scorpion_RowStack(0, 0, g)
cards = [
AbstractCard(1000+r*100+s*10, 0, s, r, g)
for s, r in [(2, 5), (3, 7), (2, 7), (2, 0),
(2, 3), (2, 4), (1, 4)]
]
for c in cards:
c.face_up = True
c.item = MockItem()
stack.addCard(c)
self.assertTrue(stack.canMoveCards(stack.cards[4:])) self.assertTrue(stack.canMoveCards(stack.cards[4:]))
self.assertTrue(stack) self.assertTrue(stack)